greggy/landingpage-haus-schleusingen
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: JavaScript doppelte Funktionen & toter Code (#39) #40

Merged
greggy merged 1 commits from feature/39-js-duplicate-functions-fix into main 2026-05-19 15:13:30 +02:00
Conversation 0 Commits 1 Files Changed 1
+8 -32
greggy commented 2026-05-19 14:55:46 +02:00
Owner
Copy Link
Copy Source

Änderungen

  • Doppelte openLightbox()/closeLightbox() Definitionen zusammengeführt (nur Vanilla JS)
  • Toter Code-Block im Keyboard-Handler entfernt (ReferenceError)

Test

  • Lightbox öffnet/schließt korrekt
  • Galerie-Klick funktioniert
  • Floor-Accordion funktioniert
  • Keyboard-Navigation (Enter/Space/Escape) funktioniert

Closes #39

## Änderungen - Doppelte `openLightbox()`/`closeLightbox()` Definitionen zusammengeführt (nur Vanilla JS) - Toter Code-Block im Keyboard-Handler entfernt (ReferenceError) ## Test - [x] Lightbox öffnet/schließt korrekt - [x] Galerie-Klick funktioniert - [x] Floor-Accordion funktioniert - [x] Keyboard-Navigation (Enter/Space/Escape) funktioniert Closes #39
greggy added 1 commit 2026-05-19 14:55:47 +02:00
fix: remove duplicate openLightbox/closeLightbox and dead code (#39)
Deploy Feature Branch to Test / deploy (push) Successful in 26s
Details
6b13b95102 
- Consolidate openLightbox() and closeLightbox() to single vanilla JS definition
- Remove orphaned keyboard handler block that caused ReferenceError
- Refs: #39
greggy merged commit 4ca48a7445 into main 2026-05-19 15:13:30 +02:00
greggy deleted branch feature/39-js-duplicate-functions-fix 2026-05-19 15:13:30 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accessibility
Accessibility / a11y (44x44px, ARIA, contrast)
 i18n
Internationalization / translation
 Implementing
InQA
InReview
InValidation
KI
Von KI bearbeitet
 KI
KI
KI
priority/P1
High priority (do soon)
 ReadyForDev
Bereit zur Implementierung
 ReadyForMerge
responsive
Responsive design (mobile/tablet/desktop)
 type/feature
Feature request (new user-facing capability)
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
greggy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: greggy/landingpage-haus-schleusingen#40