greggy/landingpage-haus-schleusingen
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(issue-80): show all 13 house images + 3D floor plans #81

Open
greggy wants to merge 1 commits from fix/issue-80-show-all-images into main
pull from: fix/issue-80-show-all-images
merge into: greggy:main
Conversation 0 Commits 1 Files Changed 6 +250 -4
greggy commented 2026-06-06 00:29:51 +02:00
Owner
Copy Link

Summary

Schließt #80 — die Galerie zeigt jetzt alle 13 Haus-Bilder und jeder Stockwerk-Plan hat einen 2D+3D-Vergleich.

Was fehlte

Inventur vorher jetzt
Bilder auf Disk (public/bilder/) 16 16
In Galerie verlinkt 9 13
Floor-Plans 2D 4 4
Floor-Plans 3D / Variante 0 4

Geänderte Dateien

  • app/views/home/index.php — $gridItems um 4 Einträge erweitert (Bad-2/3/4.jpeg, Kinderzimmer.png); neue Variable $floorImageMapExtra mit 4 3D-Pfaden; Floor-Rendering nutzt vorhandene .floor-plan-multi-Klasse (CSS-Spalten 1fr 1fr, mobil 1fr).
  • app/Locales/{de,en,uk,ru}.php — 10 neue Keys je Sprache: gallery.{bath2,bath3,bath4,kid_extra,alt.bath2,alt.bath3,alt.bath4,alt.kid_extra} + floors.alt.{eg_3d,og1_3d,og2_3d,attic_3d}.
  • tests/Views/HomeGalleryInventoryTest.php (neu) — Regression-Test, der prüft dass jedes Bild in public/bilder/ (gruppiert nach Basis-Name, also .png-Original zählt mit .webp-Auto-Variante zusammen) im View referenziert wird. Verhindert zukünftigen Drift.

Verifikation

  • php -l auf allen 5 geänderten PHP-Dateien: clean
  • PHPUnit: 144/144 grün (141 alt + 3 neu)
  • safe-commit.sh Hooks: lint-staged OK + PHPUnit OK
  • Playwright Visual-Check 4 Viewports (1920/768/375/320): ALL_OK — 13 Grid-Items, 28 imgs, 0 Console-Errors, alle 8 neuen Bilder sichtbar

Akzeptanzkriterien (from #80)

  • Alle Bilder aus public/bilder/ sichtbar
  • In allen 4 Sprachen übersetzt (DE/EN/UK/RU)
  • Alt-Texte vorhanden (geprüft via Inventory-Test)
  • Cache-Buster ?v=<filemtime> bleibt unverändert
  • PHPUnit 144/144 grün
  • Mobile-Layout (Floor-Plans stapeln sich vertikal dank grid-template-columns: 1fr @media)
## Summary Schließt #80 — die Galerie zeigt jetzt **alle 13** Haus-Bilder und jeder Stockwerk-Plan hat einen 2D+3D-Vergleich. ## Was fehlte | Inventur | vorher | jetzt | |---|---|---| | Bilder auf Disk (`public/bilder/`) | 16 | 16 | | In Galerie verlinkt | 9 | **13** | | Floor-Plans 2D | 4 | 4 | | Floor-Plans 3D / Variante | 0 | **4** | ## Geänderte Dateien - **`app/views/home/index.php`** — `$gridItems` um 4 Einträge erweitert (`Bad-2/3/4.jpeg`, `Kinderzimmer.png`); neue Variable `$floorImageMapExtra` mit 4 3D-Pfaden; Floor-Rendering nutzt vorhandene `.floor-plan-multi`-Klasse (CSS-Spalten 1fr 1fr, mobil 1fr). - **`app/Locales/{de,en,uk,ru}.php`** — 10 neue Keys je Sprache: `gallery.{bath2,bath3,bath4,kid_extra,alt.bath2,alt.bath3,alt.bath4,alt.kid_extra}` + `floors.alt.{eg_3d,og1_3d,og2_3d,attic_3d}`. - **`tests/Views/HomeGalleryInventoryTest.php`** *(neu)* — Regression-Test, der prüft dass **jedes** Bild in `public/bilder/` (gruppiert nach Basis-Name, also `.png`-Original zählt mit `.webp`-Auto-Variante zusammen) im View referenziert wird. Verhindert zukünftigen Drift. ## Verifikation - `php -l` auf allen 5 geänderten PHP-Dateien: **clean** - PHPUnit: **144/144 grün** (141 alt + 3 neu) - `safe-commit.sh` Hooks: lint-staged OK + PHPUnit OK - Playwright Visual-Check 4 Viewports (1920/768/375/320): **ALL_OK** — 13 Grid-Items, 28 imgs, 0 Console-Errors, alle 8 neuen Bilder sichtbar ## Akzeptanzkriterien (from #80) - [x] Alle Bilder aus `public/bilder/` sichtbar - [x] In allen 4 Sprachen übersetzt (DE/EN/UK/RU) - [x] Alt-Texte vorhanden (geprüft via Inventory-Test) - [x] Cache-Buster `?v=<filemtime>` bleibt unverändert - [x] PHPUnit 144/144 grün - [x] Mobile-Layout (Floor-Plans stapeln sich vertikal dank `grid-template-columns: 1fr` @media)
greggy added 1 commit 2026-06-06 00:29:51 +02:00
fix(issue-80): show all 13 house images + 3D floor plans
All checks were successful
Lint / PHP Syntax Check (push) Successful in 57s
Details
PHPUnit / PHP Unit Tests (push) Successful in 1m7s
Details
Lint / HTML Lint (htmlhint) (push) Successful in 1m38s
Details
Lint / CSS Lint (stylelint) (push) Successful in 1m42s
Details
Lint / PHP Syntax Check (pull_request) Successful in 58s
Details
PHPUnit / PHP Unit Tests (pull_request) Successful in 1m3s
Details
Lint / HTML Lint (htmlhint) (pull_request) Successful in 1m36s
Details
Lint / CSS Lint (stylelint) (pull_request) Successful in 1m41s
Details
db83e09a3a
greggy added the
i18n
KI
ReadyForDev
 labels 2026-06-06 00:32:02 +02:00
All checks were successful
Lint / PHP Syntax Check (push) Successful in 57s
Details
PHPUnit / PHP Unit Tests (push) Successful in 1m7s
Details
Lint / HTML Lint (htmlhint) (push) Successful in 1m38s
Details
Lint / CSS Lint (stylelint) (push) Successful in 1m42s
Details
Lint / PHP Syntax Check (pull_request) Successful in 58s
Required
Details
PHPUnit / PHP Unit Tests (pull_request) Successful in 1m3s
Details
Lint / HTML Lint (htmlhint) (pull_request) Successful in 1m36s
Required
Details
Lint / CSS Lint (stylelint) (pull_request) Successful in 1m41s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/issue-80-show-all-images:fix/issue-80-show-all-images
git checkout fix/issue-80-show-all-images
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accessibility
Accessibility / a11y (44x44px, ARIA, contrast)
i18n
Internationalization / translation
Implementing
InQA
InReview
InValidation
KI
Von KI bearbeitet
KI
KI
KI
priority/P1
High priority (do soon)
ReadyForDev
Bereit zur Implementierung
ReadyForMerge
responsive
Responsive design (mobile/tablet/desktop)
type/feature
Feature request (new user-facing capability)
No Label
i18n
KI
ReadyForDev
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
greggy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: greggy/landingpage-haus-schleusingen#81
No description provided.
Delete Branch "fix/issue-80-show-all-images"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?