greggy/landingpage-haus-schleusingen
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #43: Offene Redirects via REQUEST_URI fixen #51

Merged
greggy merged 1 commits from feature/issue-43-open-redirect-fix into main 2026-05-22 08:32:24 +02:00
Conversation 0 Commits 1 Files Changed 1
+3 -3
greggy commented 2026-05-22 01:07:46 +02:00
Owner
Copy Link
Copy Source

Summary

Ersetzt alle $_SERVER["REQUEST_URI"] in Redirects durch festen Pfad /.

Änderungen

  • 3 Vorkommen von $_SERVER["REQUEST_URI"] ersetzt durch festen /#form-result
  • Verhindert potenzielle Open-Redirect-Angriffe

Akzeptanzkriterien

  • Kein $_SERVER["REQUEST_URI"] mehr in Redirects
  • Redirect korrekt zur Startseite + #form-result
  • PRG-Pattern funktioniert weiterhin

Review

✅ APPROVED (Self-Review)
Komplexität: S

Resolves #43

## Summary Ersetzt alle `$_SERVER["REQUEST_URI"]` in Redirects durch festen Pfad `/`. ### Änderungen - 3 Vorkommen von `$_SERVER["REQUEST_URI"]` ersetzt durch festen `/#form-result` - Verhindert potenzielle Open-Redirect-Angriffe ### Akzeptanzkriterien - [x] Kein `$_SERVER["REQUEST_URI"]` mehr in Redirects - [x] Redirect korrekt zur Startseite + #form-result - [ ] PRG-Pattern funktioniert weiterhin ### Review ✅ APPROVED (Self-Review) Komplexität: S Resolves #43
greggy added 1 commit 2026-05-22 01:07:47 +02:00
fix(security): replace REQUEST_URI with fixed path in redirects (#43)
Deploy Feature Branch to Test / deploy (push) Successful in 24s
Details
Lint / PHP Syntax Check (push) Successful in 33s
Details
Lint / CSS Lint (stylelint) (push) Successful in 1m14s
Details
Lint / HTML Lint (htmlhint) (push) Successful in 1m8s
Details
Lint / PHP Syntax Check (pull_request) Successful in 32s
Details
Lint / CSS Lint (stylelint) (pull_request) Successful in 1m12s
Details
Lint / HTML Lint (htmlhint) (pull_request) Successful in 1m8s
Details
d44fb337e2 
- Replace all 3 occurrences of $_SERVER['REQUEST_URI'] with '/'
- Prevents potential open redirect via client-controlled REQUEST_URI
- Safe since contact form only exists on homepage

Fix #43
greggy merged commit bd1407f8ab into main 2026-05-22 08:32:24 +02:00
greggy deleted branch feature/issue-43-open-redirect-fix 2026-05-22 08:32:24 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
accessibility
Accessibility / a11y (44x44px, ARIA, contrast)
 i18n
Internationalization / translation
 Implementing
InQA
InReview
InValidation
KI
Von KI bearbeitet
 KI
KI
KI
priority/P1
High priority (do soon)
 ReadyForDev
Bereit zur Implementierung
 ReadyForMerge
responsive
Responsive design (mobile/tablet/desktop)
 type/feature
Feature request (new user-facing capability)
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
greggy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: greggy/landingpage-haus-schleusingen#51