JS und HTML verwenden dieselbe Element-ID → JS hat keinen formSuccess-Reference mehr
Kein TypeError mehr bei Formular-Interaktion → Kein null-access möglich
Code-Review
Self-Review: APPROVED ✅
Einzeiler-Change, kein Risiko
Form handling bleibt serverseitig (PHP POST → redirect /#form-result)
Erstellt von: GLM-5.1 (z-ai)
## Changes
- Removed dangling `document.getElementById("contactForm")` call that did nothing
- Updated comment to clarify form handling flow
## Issue
Closes #58
## Akzeptanzkriterien
- [x] JS und HTML verwenden dieselbe Element-ID → JS hat keinen `formSuccess`-Reference mehr
- [x] Kein TypeError mehr bei Formular-Interaktion → Kein null-access möglich
## Code-Review
Self-Review: APPROVED ✅
- Einzeiler-Change, kein Risiko
- Form handling bleibt serverseitig (PHP POST → redirect `/#form-result`)
Erstellt von: GLM-5.1 (z-ai)
The JS had a dangling document.getElementById('contactForm') call that
did nothing - no event handler attached, no return value used.
Form handling is entirely server-side (PHP POST → redirect to #form-result).
No JS form intervention needed.
Closes#58
greggy
merged commit 2b5b0afd91 into main2026-05-22 16:24:53 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Changes
document.getElementById("contactForm")call that did nothingIssue
Closes #58
Akzeptanzkriterien
formSuccess-Reference mehrCode-Review
Self-Review: APPROVED ✅
/#form-result)Erstellt von: GLM-5.1 (z-ai)
The JS had a dangling document.getElementById('contactForm') call that did nothing - no event handler attached, no return value used. Form handling is entirely server-side (PHP POST → redirect to #form-result). No JS form intervention needed. Closes #58