greggy/landingpage-haus-schleusingen
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#58): Remove broken getElementById form stub #61

Merged
greggy merged 1 commits from feature/issue-58-fix-formsuccess into main 2026-05-22 16:24:53 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -2
greggy commented 2026-05-22 16:14:44 +02:00
Owner
Copy Link

Changes

  • Removed dangling document.getElementById("contactForm") call that did nothing
  • Updated comment to clarify form handling flow

Issue

Closes #58

Akzeptanzkriterien

  • JS und HTML verwenden dieselbe Element-ID → JS hat keinen formSuccess-Reference mehr
  • Kein TypeError mehr bei Formular-Interaktion → Kein null-access möglich

Code-Review

Self-Review: APPROVED ✅

  • Einzeiler-Change, kein Risiko
  • Form handling bleibt serverseitig (PHP POST → redirect /#form-result)

Erstellt von: GLM-5.1 (z-ai)

## Changes - Removed dangling `document.getElementById("contactForm")` call that did nothing - Updated comment to clarify form handling flow ## Issue Closes #58 ## Akzeptanzkriterien - [x] JS und HTML verwenden dieselbe Element-ID → JS hat keinen `formSuccess`-Reference mehr - [x] Kein TypeError mehr bei Formular-Interaktion → Kein null-access möglich ## Code-Review Self-Review: APPROVED ✅ - Einzeiler-Change, kein Risiko - Form handling bleibt serverseitig (PHP POST → redirect `/#form-result`) Erstellt von: GLM-5.1 (z-ai)
greggy added 1 commit 2026-05-22 16:14:44 +02:00
fix(#58): remove broken getElementById('contactForm') stub
All checks were successful
Deploy Feature Branch to Test / deploy (push) Successful in 26s
Details
Lint / PHP Syntax Check (push) Successful in 35s
Details
Lint / CSS Lint (stylelint) (push) Successful in 1m15s
Details
Lint / HTML Lint (htmlhint) (push) Successful in 1m11s
Details
Lint / PHP Syntax Check (pull_request) Successful in 39s
Details
Lint / CSS Lint (stylelint) (pull_request) Successful in 1m13s
Details
Lint / HTML Lint (htmlhint) (pull_request) Successful in 1m12s
Details
3db7dc8971 
The JS had a dangling document.getElementById('contactForm') call that
did nothing - no event handler attached, no return value used.

Form handling is entirely server-side (PHP POST → redirect to #form-result).
No JS form intervention needed.

Closes #58
greggy merged commit 2b5b0afd91 into main 2026-05-22 16:24:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Implementing
InQA
InReview
InValidation
KI
Von KI bearbeitet
KI
KI
KI
ReadyForDev
Bereit zur Implementierung
ReadyForMerge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
greggy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: greggy/landingpage-haus-schleusingen#61
No description provided.
Delete Branch "feature/issue-58-fix-formsuccess"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?